From kde-commits Mon Dec 20 19:37:43 2004 From: David Faure Date: Mon, 20 Dec 2004 19:37:43 +0000 To: kde-commits Subject: kdelibs/kio Message-Id: <20041220193743.0A7EF1CF5B () office ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-commits&m=110357147130481 CVS commit by faure: When rename() fails, for any reason other than file_exists/dir_exists/unsupported, i.e. a real reason (access denied, does not exist etc.), just stop the job there instead of attempting the copy+del method. Side effects: fixes a kio_trash bug, and doesn't leave around the destination file when trying to move(/rename) on the same partition (consistent with "mv") Added regression tests for move() in multiple cases, including the "access denied" case. M +8 -2 kio/job.cpp 1.427 M +2 -4 kio/job.h 1.105 M +131 -1 tests/jobtest.cpp 1.5 M +8 -0 tests/jobtest.h 1.5