[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs
From:       Benjamin Meyer <ben () meyerhome ! net>
Date:       2004-12-20 16:03:35
Message-ID: 200412201103.37752.ben () meyerhome ! net
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 20 December 2004 9:31 am, you wrote:
> On Monday 20 December 2004 08:28 am, Benjamin Meyer wrote:
> > CVS commit by bmeyer:
> >
> > Some depricated doc changes
> >
> >
> >   M +3 -3      kdecore/kaccel.h   1.103
> >   M +1 -1      kdeui/kstdaction.h   1.50
> >
> >
> > --- kdelibs/kdecore/kaccel.h  #1.102:1.103
> > @@ -351,9 +351,9 @@ class KDECORE_EXPORT KAccel : public QAc
> >          bool setItemEnabled( const QString& sAction, bool bEnable )
> > KDE_DEPRECATED; /**
> > -         * @deprecated
> > +         * @deprecated see KDE3PORTING.html
> >           */
> >          void changeMenuAccel( QPopupMenu *menu, int id, const QString&
> > action ) KDE_DEPRECATED; /**
> > -         * @deprecated
> > +         * @deprecated see KDE3PORTING.html
> >           */
> >          void changeMenuAccel( QPopupMenu *menu, int id,
> > KStdAccel::StdAccel accel ) KDE_DEPRECATED;
>
> C'mon, give me a break. If you're going to take the effort to add
> docstrings. You might as well make them useful rather than just pointing
> people to yet another HTML page.
>
> Matt

As I am not too familiar with the old code I didn't want to write docs that 
would be incorrect.  I did contemplate coping a little bit from 
KDE3PORTING.html, but the the real fix has to do with porting to KAction 
which is much beter explained in the porting doc (and takes up a bit of 
room).

- -Benjamin Meyer

- -- 
aka icefox
Public Key: http://www.icefox.net/public_key.asc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBxvfX1rZ3LTw38vIRAmZSAKCtqcHRN4jSKg7Naa17Ov4TTQo1VQCdF0we
pHUcm6BnRvjGlig4v4/Lsp8=
=13CL
-----END PGP SIGNATURE-----
[prev in list] [next in list] [prev in thread] [next in thread]