[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdelibs/khtml/html
From:       Koos Vriezen <koos.vriezen () xs4all ! nl>
Date:       2004-12-02 18:47:29
Message-ID: 20041202184729.BA1461B914 () office ! kde ! org
[Download RAW message or body]

CVS commit by vriezen: 

Bah, HTMLCollectionImpl::item must be reimplemented too because of the
failing base->firstChild() in HTMLFormCollectionImpl.


  M +6 -0      html_miscimpl.cpp   1.45
  M +3 -2      html_miscimpl.h   1.32


--- kdelibs/khtml/html/html_miscimpl.h  #1.31:1.32
@@ -76,6 +76,6 @@ public:
     unsigned long length() const;
     // Only when iterating forward, it will use caching, ie. making it O(1).
-    NodeImpl *item ( unsigned long index ) const;
-    // obsolete and not domtree changes save, virtual too.
+    virtual NodeImpl *item ( unsigned long index ) const;
+    // obsolete and not domtree changes save
     virtual NodeImpl *firstItem() const;
     virtual NodeImpl *nextItem() const;
@@ -127,4 +127,5 @@ public:
     ~HTMLFormCollectionImpl() { }
 
+    virtual NodeImpl *item ( unsigned long index ) const;
     virtual NodeImpl *firstItem() const;
     virtual NodeImpl *nextItem() const;

--- kdelibs/khtml/html/html_miscimpl.cpp  #1.44:1.45
@@ -524,4 +524,10 @@ NodeImpl *HTMLCollectionImpl::nextNamedI
 // -----------------------------------------------------------------------------
 
+NodeImpl *HTMLFormCollectionImpl::item( unsigned long index ) const
+{
+    int dummy;
+    return getItem(0L, index, dummy);
+}
+
 unsigned long HTMLFormCollectionImpl::calcLength(NodeImpl*) const
 {


[prev in list] [next in list] [prev in thread] [next in thread]