[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE_3_3_BRANCH: kdepim/kontact/src
From:       David Faure <faure () kde ! org>
Date:       2004-11-30 21:27:43
Message-ID: 20041130212743.15D9D1BA73 () office ! kde ! org
[Download RAW message or body]

CVS commit by faure: 

Don't call hide() on the current widget, it leads to the main kontact area
not repainting itself at all, which looks very weird.
This came from the fact that the todo and calendar plugins share the same part,
so partLoaded() is called twice with the same part.
How to reproduce the bug: https://intevation.de/roundup/kolab/issue555


  M +5 -2      mainwindow.cpp   1.124.2.3


--- kdepim/kontact/src/mainwindow.cpp  #1.124.2.2:1.124.2.3
@@ -452,5 +452,8 @@ void MainWindow::addPlugin( Kontact::Plu
 void MainWindow::partLoaded( Kontact::Plugin * /*plugin*/, KParts::Part *part )
 {
-  if ( part->widget() )
+  // See if we have this part already (e.g. due to two plugins sharing it)
+  if ( mStack->id( part->widget() ) != -1 )
+    return;
+
     mStack->addWidget( part->widget(), 0 );
 


[prev in list] [next in list] [prev in thread] [next in thread]