[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kdeui
From:       "Barry O'Donovan" <barry.odonovan () kdemail ! net>
Date:       2004-11-28 10:32:38
Message-ID: 200411281032.49999.barry.odonovan () kdemail ! net
[Download RAW message or body]


On Sunday 28 November 2004 03:24, Zack Rusin wrote:
> On Saturday 27 November 2004 20:19, Barry O'Donovan wrote:
> Do me a huge favor and don't be committing code on a per favor basis,

I do not commit code "on a per favor basis" - I committed on a specific 
request from Andrew Coles whom, as I subscribe to kde-devel, 
kde-core-devel and kde-cvs, I know has been and still is actively 
working on KPasswordDialog(). 

I am aware that there was a thread on kde-core relating to this which 
included yourself. That thread ended at 17.39 (my time). Andrew's 
request came in at 20.56. I committed at 01.19 after no further commits 
or conversation occurred.

Before committing I ensured:
  - that the patch made sense;
  - that the code compiled; and
  - that a pre-commit diff showed only the intended changes.

I committed Andrew's patch for the very reason that, had he CVS access, 
he would have done it himself and he was attempting to repair _his own 
code_.


I apologise for trying to be helpful in a knowledgable and considered 
manner,

Kind regards,
Barry.

> especially if another patch fixing the same bug has already been
> approved. OK?
>
> Zack

-- 
Regards,
Barry O'Donovan
http://www.barryodonovan.com/
http://www.ihl.ucd.ie/		

Public key: http://www.barryodonovan.com/gpg.asc


[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]