[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/kcontrol/kfontinst
From:       Scott Wheeler <wheeler () kde ! org>
Date:       2004-11-25 18:49:57
Message-ID: 200411251949.57417.wheeler () kde ! org
[Download RAW message or body]

On Thursday 18 November 2004 22:38, Craig Drummond wrote:
> CVS commit by craig:
>
> Fix for fontconfig < 2.2
>
>
>   M +2 -2      configure.in.in   1.25
>   M +13 -13    kfile-plugin/KFileFont.cpp   1.14
>   M +6 -2      kio/KioFonts.cpp   1.45
>   M +15 -13    lib/FcEngine.cpp   1.5
>   M +14 -6     lib/FcEngine.h   1.4

This doesn't fix things, it just breaks them a different way.  It doesn't make 
much sense to leave the function declarations in the header and to #ifdef out 
the implementation.  When those are used it just leaves unresolved symbols.

Also while looking through this code I noticed a lot of stuff like:

i18n(KFI_WEIGHT_THIN)

Which I'm pretty sure doesn't work.

-Scott

-- 
Had this been an actual emergency, we would have fled in terror, and you would 
not have been informed.
[prev in list] [next in list] [prev in thread] [next in thread]