[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/libkonq
From:       David Faure <faure () kde ! org>
Date:       2004-11-25 9:57:11
Message-ID: 200411251057.11518.faure () kde ! org
[Download RAW message or body]

On Thursday 25 November 2004 08:02, Aaron J. Seigo wrote:
> CVS commit by aseigo: 
> 
> clean up the code as per dfaure's comment
> 
> 
>   M +10 -22    konq_popupmenu.cc   1.208
> 
> 
> --- kdebase/libkonq/konq_popupmenu.cc  #1.207:1.208
> @@ -672,22 +672,15 @@ void KonqPopupMenu::setup(KonqPopupFlags
>                          // we could cram the following three if statements into
>                          // one gigantic boolean statement but that would be a
> -                        // hororr show for readability
> +                        // horror show for readability
>                          // DF: ok, but every if() could set a bool, and then the code to actually
>                          // run in there (excludeTypes etc.) could be done only in one place.
> +                        // AJS: fair enough, let thy will be done =)

:)
Thanks.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]