[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    proko2: kdepim/kresources/kolab
From:       David Faure <faure () kde ! org>
Date:       2004-11-17 13:58:02
Message-ID: 20041117135802.64F5216BB7 () office ! kde ! org
[Download RAW message or body]

CVS commit by faure: 

Repaint the dialog only, don't process all events (which triggered some repaint code
in the app, which triggered loading again)


  M +2 -0      kabc/resourcekolab.cpp   1.1.2.33
  M +3 -1      kcal/resourcekolab.cpp   1.1.2.48


--- kdepim/kresources/kolab/kabc/resourcekolab.cpp  #1.1.2.32:1.1.2.33
@@ -202,5 +202,7 @@ bool KABC::ResourceKolab::loadSubResourc
     // Note that this is a case where processEvents is OK - we have a modal dialog,
     // the only thing the user can do is cancel the dialog.
+    // WRONG - repainting happens, which triggers loading again
     //qApp->processEvents();
+    progress.repaint();
     if ( progress.wasCanceled() )
       return false;

--- kdepim/kresources/kolab/kcal/resourcekolab.cpp  #1.1.2.47:1.1.2.48
@@ -181,5 +181,7 @@ bool ResourceKolab::loadSubResource( con
     // Note that this is a case where processEvents is OK - we have a modal dialog,
     // the only thing the user can do is cancel the dialog.
-    qApp->processEvents();
+    // WRONG: repainting happens too...
+    //qApp->processEvents();
+    progress.repaint();
     if ( progress.wasCanceled() )
       return false;


[prev in list] [next in list] [prev in thread] [next in thread]