[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdelibs/khtml/ecma
From:       George Staikos <staikos () kde ! org>
Date:       2004-11-15 21:51:39
Message-ID: 20041115215139.1563216BC4 () office ! kde ! org
[Download RAW message or body]

CVS commit by staikos: 

the comment was right, this code was wrong.  Tested in IE and Mozilla, we now
behave as they do.  The result: JS popups are now generally without scrollbars.


  M +2 -6      kjs_window.cpp   1.392


--- kdelibs/khtml/ecma/kjs_window.cpp  #1.391:1.392
@@ -1247,11 +1247,7 @@ void KJS::Window::resizeTo(QWidget* tl, 
 
   // Take into account the window frame - so that (width,height) is the external window size
-  // ### (is that correct? for window.open it's the size of the HTML area...)
-  int deltaWidth = tl->frameGeometry().width() - tl->width();
-  int deltaHeight = tl->frameGeometry().height() - tl->height();
-
-  kdDebug() << "resizing to " << width - deltaWidth << "x" << height - deltaHeight << endl;
+  kdDebug() << "resizing to " << width << "x" << height << endl;
 
-  emit ext->resizeTopLevelWidget( width - deltaWidth, height - deltaHeight );
+  emit ext->resizeTopLevelWidget( width, height );
 
   // If the window is out of the desktop, move it up/left


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic