[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE_3_3_BRANCH: kdepim/kmail
From:       David Faure <faure () kde ! org>
Date:       2004-11-10 10:10:57
Message-ID: 20041110101057.A308F16C2B () office ! kde ! org
[Download RAW message or body]

CVS commit by faure: 

Swap two lines and gain some performance when parsing big folders. Approved by Don.


  M +2 -3      kmfoldermaildir.cpp   1.96.2.1
  M +2 -2      kmfoldermbox.cpp   1.111.2.1


--- kdepim/kmail/kmfoldermbox.cpp  #1.111:1.111.2.1
@@ -782,7 +782,7 @@ KMMessage* KMFolderMbox::readMsg(int idx
   assert(mStream != 0);
 
-  KMMessage* msg = new KMMessage(*mi);
+  KMMessage* msg = new KMMessage(*mi); // note that mi is deleted by the line below
+  mMsgList.set(idx,&msg->toMsgBase()); // done now so that the serial number can be computed
   msg->fromDwString( getDwString( idx ) );
-  mMsgList.set(idx,&msg->toMsgBase());
 
   return msg;

--- kdepim/kmail/kmfoldermaildir.cpp  #1.96:1.96.2.1
@@ -519,8 +519,7 @@ KMMessage* KMFolderMaildir::readMsg(int 
 {
   KMMsgInfo* mi = (KMMsgInfo*)mMsgList[idx];
-  KMMessage *msg = new KMMessage(*mi);
-
+  KMMessage *msg = new KMMessage(*mi); // note that mi is deleted by the line below
+  mMsgList.set(idx,&msg->toMsgBase()); // done now so that the serial number can be computed
   msg->fromDwString(getDwString(idx));
-  mMsgList.set(idx,&msg->toMsgBase());
   return msg;
 }


[prev in list] [next in list] [prev in thread] [next in thread]