[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdebase/kcontrol/icons
From:       Benjamin Meyer <benjamin () csh ! rit ! edu>
Date:       2004-11-05 18:48:11
Message-ID: 20041105184811.A372516DBE () office ! kde ! org
[Download RAW message or body]

CVS commit by bmeyer: 

use const, correct defines, remove filenames, const iterator


  M +4 -6      iconthemes.cpp   1.49
  M +7 -8      iconthemes.h   1.7


--- kdebase/kcontrol/icons/iconthemes.cpp  #1.48:1.49
@@ -1,5 +1,3 @@
 /**
- *  icontheme.cpp
- *
  *  Copyright (c) 2000 Antonio Larrosa <larrosa@kde.org>
  *
@@ -117,5 +115,5 @@ IconThemesConfig::~IconThemesConfig()
 }
 
-QListViewItem *IconThemesConfig::iconThemeItem(QString name)
+QListViewItem *IconThemesConfig::iconThemeItem(const QString &name)
 {
   QListViewItem *item;
@@ -205,5 +203,5 @@ void IconThemesConfig::installNewTheme()
 }
 
-bool IconThemesConfig::installThemes(QStringList themes, QString archiveName)
+bool IconThemesConfig::installThemes(const QStringList &themes, const QString &archiveName)
 {
   bool everythingOk = true;
@@ -225,5 +223,5 @@ bool IconThemesConfig::installThemes(QSt
 
   KArchiveDirectory* currentTheme;
-  for (QStringList::Iterator it = themes.begin();
+  for (QStringList::ConstIterator it = themes.begin();
        it != themes.end();
        ++it) {
@@ -254,5 +252,5 @@ bool IconThemesConfig::installThemes(QSt
 }
 
-QStringList IconThemesConfig::findThemeDirs(QString archiveName)
+QStringList IconThemesConfig::findThemeDirs(const QString &archiveName)
 {
   QStringList foundThemes;

--- kdebase/kcontrol/icons/iconthemes.h  #1.6:1.7
@@ -1,5 +1,3 @@
 /**
- * midi.h
- *
  * Copyright (c) 2000 Antonio Larrosa <larrosa@kde.org>
  *
@@ -19,6 +17,6 @@
  */
 
-#ifndef __midi_h__
-#define __midi_h__
+#ifndef ICONTHEMES_H
+#define ICONTHEMES_H
 
 #include <kcmodule.h>
@@ -41,6 +39,6 @@ public:
 
   void loadThemes();
-  bool installThemes(QStringList themes, QString archiveName);
-  QStringList findThemeDirs(QString archiveName);
+  bool installThemes(const QStringList &themes, const QString &archiveName);
+  QStringList findThemeDirs(const QString &archiveName);
 
   void updateRemoveButton();
@@ -58,5 +56,5 @@ protected slots:
 
 private:
-  QListViewItem *iconThemeItem(QString name);
+  QListViewItem *iconThemeItem(const QString &name);
 
   QListView *m_iconThemes;
@@ -71,3 +69,4 @@ private:
 };
 
-#endif
+#endif // ICONTHEMES_H
+


[prev in list] [next in list] [prev in thread] [next in thread]