[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdegames
From:       Albert Astals Cid <tsdgeos () terra ! es>
Date:       2004-11-02 20:13:32
Message-ID: 20041102201332.B2F9516C9D () office ! kde ! org
[Download RAW message or body]

CVS commit by aacid: 

Please a bit icefox scripts


  M +1 -1      kbattleship/kbattleship/kbattleship.cpp   1.153
  M +1 -1      kbattleship/kbattleship/kbattleshipview.cpp   1.60
  M +1 -1      kbattleship/kbattleship/kgridwidget.cpp   1.53
  M +1 -1      kbattleship/kbattleship/kgridwidget.h   1.38
  M +2 -2      kgoldrunner/src/kgrdialog.cpp   1.15
  M +1 -1      kgoldrunner/src/kgrdialog.h   1.2
  M +1 -1      kpoker/kpoker.cpp   1.85


--- kdegames/kbattleship/kbattleship/kbattleship.cpp  #1.152:1.153
@@ -915,5 +915,5 @@ void KBattleshipApp::slotLost(KMessage *
 {
         m_stat->slotAddEnemyWon();
-        if (msg->field("ship0") != QString::null) m_view->drawEnemyShipsHuman(msg, \
m_enemyshiplist); +        if (!msg->field("ship0").isNull()) \
m_view->drawEnemyShipsHuman(msg, m_enemyshiplist);  m_lost = true;
 }

--- kdegames/kbattleship/kbattleship/kbattleshipview.cpp  #1.59:1.60
@@ -108,5 +108,5 @@ void KBattleshipView::drawEnemyShipsHuma
         bool left;
         int i = 3;
-        while (msg->field(QString("ship%1").arg(i)) != QString::null)
+        while (!msg->field(QString("ship%1").arg(i)).isNull())
         {
                 posx = msg->field(QString("ship%1").arg(i)).section(" ", 0, \
0).toInt();

--- kdegames/kbattleship/kbattleship/kgridwidget.cpp  #1.52:1.53
@@ -366,5 +366,5 @@ void KGridWidget::drawShipIcon(int ship,
 }
 
-void KGridWidget::drawIcon(QPixmap icon, bool hitBlend, bool waterBlend, bool \
rotate) +void KGridWidget::drawIcon(const QPixmap &icon, bool hitBlend, bool \
waterBlend, bool rotate)  {
         QPainter painter;

--- kdegames/kbattleship/kbattleship/kgridwidget.h  #1.37:1.38
@@ -44,5 +44,5 @@ protected:
 private:
         void cacheImages();
-        void drawIcon(QPixmap icon, bool hitBlend = false, bool waterBlend = false, \
bool rotate = false); +        void drawIcon(const QPixmap &icon, bool hitBlend = \
false, bool waterBlend = false, bool rotate = false);  QString findIcon(const QString \
&name) const;  

--- kdegames/kgoldrunner/src/kgrdialog.cpp  #1.14:1.15
@@ -190,5 +190,5 @@ KGrSLDialog::KGrSLDialog (int action, in
     default:            break;                  // Keep the default settings.
     }
-    if (OKText != "") {
+    if (OKText.isEmpty()) {
 #ifdef KGR_PORTABLE
         OK->setText (OKText);
@@ -859,5 +859,5 @@ void KGrLGDialog::lgSelect (int n)
 *******************************************************************************/
 
-void KGrMessage::information (QWidget * parent, QString caption, QString text)
+void KGrMessage::information (QWidget * parent, const QString &caption, const \
QString &text)  {
 #ifdef KGR_PORTABLE

--- kdegames/kgoldrunner/src/kgrdialog.h  #1.1:1.2
@@ -210,5 +210,5 @@ class KGrMessage : public QDialog
 {
 public:
-    static void information (QWidget * parent, QString caption, QString text);
+    static void information (QWidget * parent, const QString &caption, const QString \
&text);  static int warning (QWidget * parent, QString caption, QString text,
                         QString label0, QString label1, QString label2 = "");

--- kdegames/kpoker/kpoker.cpp  #1.84:1.85
@@ -645,5 +645,5 @@ void kpok::paintCash()
 void kpok::updateLHLabel()
 {
-  if (lastHandText != "")
+  if (lastHandText.isEmpty())
     setHand(lastHandText);
   else if (getPlayers() > 1)


[prev in list] [next in list] [prev in thread] [next in thread]