[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/khtml [POSSIBLY UNSAFE]
From:       David Faure <faure () kde ! org>
Date:       2004-11-02 10:47:39
Message-ID: 200411021147.40096.faure () kde ! org
[Download RAW message or body]

On Monday 01 November 2004 19:08, Allan Sandfeld Jensen wrote:
> On Monday 01 November 2004 16:56, David Faure wrote:
> > On Saturday 30 October 2004 12:34, Allan Sandfeld Jensen wrote:
> > > On Friday 29 October 2004 20:46, you wrote:
> > > > On Friday 29 October 2004 20:40, David Faure wrote:
> > > > i.e. document.layers would only work when choosing a netscape UA.
> > >
> > > As I understand NetscapeCompat is also set when we emulate Mozilla. When
> > > doing that we still dont want to be treated as a Netscape4.
> >
> > Right. Well you could use  KProtocolManager::userAgentForHost( url.host() )
> > to check for NS4, a bit like KJSProxyImpl::applyUserAgent().
> 
> No, I just needed to improve the hiding feature.
I disagree.

> Here is a nice and evil patch for you.
> 
> I am leaning towards reverting, but being evil is fun ;)

Sure, you can fix it for that code, but how many breakages are yet to come?
How can you know all the ways the websites out there use layers, to make sure
the "hiding" feature leads to the layers api being "hidden just enough, but not too much"?

Either it should be only present when UA==NS4, for full NS4 emulation, or it should not be present.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]