[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdelibs/khtml/html
From:       Koos Vriezen <koos.vriezen () xs4all ! nl>
Date:       2004-10-28 21:23:22
Message-ID: 20041028212322.1044E16C1C () office ! kde ! org
[Download RAW message or body]

CVS commit by vriezen: 

Regression from collection cache implementation:
don't reset the already passed position all the time (wrongly copied from
nextItem(), copied right but wrong in this context)

BUG: 92236


  M +2 -4      html_miscimpl.cpp   1.43


--- kdelibs/khtml/html/html_miscimpl.cpp  #1.42:1.43
@@ -274,9 +274,7 @@ NodeImpl *HTMLCollectionImpl::item( unsi
     while (!node && info->current->parentNode() && info->current->parentNode() != base) {
         info->current = info->current->parentNode();
-        if (info->current->nextSibling()) {
-            pos = (int) info->position + 1;
+        if (info->current->nextSibling())
             node = getItem(info->current->nextSibling(), index, pos);
         }
-    }
     info->current = node;
     info->position = index;


[prev in list] [next in list] [prev in thread] [next in thread]