[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdemultimedia/noatun/modules/splitplaylist
From:       Stefan Gehn <mETz81 () web ! de>
Date:       2004-10-20 20:43:56
Message-ID: 20041020204356.68BBC16C38 () office ! kde ! org
[Download RAW message or body]

CVS commit by metz: 

- return false for listVisible() if the window is minimized/shaded/on another \
                desktop/hidden
- make sure the playlist window opens on current desktop on showList(), opening on \
another desktop is too confusing

TODO: also unshade a shaded window on showList(), I cannot test this right now \
because kwin is awfully broken and crashes all the time when showing shaded+hidden \
                windows again.
BUG: 54303


  M +5 -1      playlist.cpp   1.53


--- kdemultimedia/noatun/modules/splitplaylist/playlist.cpp  #1.52:1.53
@@ -6,4 +6,5 @@
 #include <krandomsequence.h>
 #include <kdebug.h>
+#include <kwin.h>
 
 #include <kiconloader.h>
@@ -168,12 +169,15 @@ PlaylistItem SplitPlaylist::getAfter(con
 bool SplitPlaylist::listVisible() const
 {
-        return view->isVisible();
+        KWin::WindowInfo info = KWin::windowInfo(view->winId());
+        return !(info.hasState(NET::Shaded) || info.hasState(NET::Hidden) || \
!info.valid() || !info.isOnCurrentDesktop());  }
 
 void SplitPlaylist::showList()
 {
+        KWin::setOnDesktop(view->winId(), KWin::currentDesktop());
         view->show();
         if (view->isMinimized())
                 view->showNormal();
+        view->raise();
 }
 


[prev in list] [next in list] [prev in thread] [next in thread]