[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: new_kcm_code: kdelibs/kutils
From:       Frans Englich <frans.englich () telia ! com>
Date:       2004-10-11 19:44:37
Message-ID: 200410111944.37614.frans.englich () telia ! com
[Download RAW message or body]

On Monday 11 October 2004 19:29, Frans Englich wrote:
> CVS commit by englich:
>
> Small cleanups:
> - Forward port win32 merge

> - Make reportError public, needed by KCModuleProxy

I have a question:

The binary compat doc:
http://developer.kde.org/documentation/library/kdeqt/kde3arch/devel-binarycompatibility.html

says this; "The only compiler affected by this, that we know of, is MSVC++, 
and KDE doesn't compile on Windows anyway," about changing scope of methods. 
Since we support now MSVC++, it renders that false, right? In other words, ok 
to commit attached?


Cheers,

		Frans



["binary.diff" (text/x-diff)]

Index: library/kdeqt/kde3arch/devel-binarycompatibility.html
===================================================================
RCS file: /home/kde/developer.kde.org/documentation/library/kdeqt/kde3arch/devel-binarycompatibility.html,v
 retrieving revision 1.9
diff -u -3 -p -r1.9 devel-binarycompatibility.html
--- library/kdeqt/kde3arch/devel-binarycompatibility.html	14 Apr 2003 09:49:01 \
                -0000	1.9
+++ library/kdeqt/kde3arch/devel-binarycompatibility.html	11 Oct 2004 19:34:14 -0000
@@ -99,8 +99,6 @@ private function protected or even publi
 function that calls the private one. <b>Note:</b> for KDE code
 it is accepted to make methods (not data members) more accessible
 (i.e. changing private->protected->public).
-The only compiler affected by this, that we know of, is MSVC++,
-and KDE doesn't compile on Windows anyway.
 
 <li> add new data members to a class or change order of data members
 in a class (doesn't apply to static ones).



[prev in list] [next in list] [prev in thread] [next in thread]