[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kdeui
From:       Nicolas Goutte <nicolasg () snafu ! de>
Date:       2004-10-06 8:00:18
Message-ID: 200410061000.18113.nicolasg () snafu ! de
[Download RAW message or body]

On Tuesday 05 October 2004 21:46, Adriaan de Groot wrote:
> On Tuesday 05 October 2004 14:21, Nicolas Goutte wrote:
> > On Monday 04 October 2004 20:37, Adriaan de Groot wrote:
> > > CVS commit by adridg:
> > >
> > > Restore X11 rgb.txt support.
> >
> > This not restoring, that is a new feature.
>
> I'm sorry, I was under the impression that the QColor(const QString &name)
> constructor did a setNamedColor(), which is documented as accepting (among
> others): 'A name from the X color database (rgb.txt) (e.g. "steelblue" or
> "gainsboro"). These color names also work under Windows. ' Since your
> previous fix broke that by _always_ prepending the "#", I thought this
> would be an acceptable change.

What I meant is that your change remains in the middle.

It does not lift the 13 character limit that is currently on the line edit. 
Therefore colors like "blanched almond" are not supported.

Also it limits the HTML-like colors to the 3 and 6 digits versions, but Qt has 
even longer ones (even if I am not sure that anybody would use them.)

So perhaps a solution would to still prepend the # if it is not there and if 
it is an invalid colour, try directly what the user has entered. (As written, 
color names are not the priority, as this dialog has them already.)

Have a nice day!

[prev in list] [next in list] [prev in thread] [next in thread]