[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kioslave/http/kcookiejar
From:       Waldo Bastian <bastian () kde ! org>
Date:       2004-10-04 20:22:51
Message-ID: 200410042222.55110.bastian () kde ! org
[Download RAW message or body]


On Sunday 03 October 2004 20:48, Benjamin Meyer wrote:
> If you called
> dcop kcookiejar kcookiejar getDomainAdvice http://www.slashdot.org
> domains[0] = .slashdot.org
> domains[1] = slashdot.org
>
> The best example:
> dcop kcookiejar kcookiejar getDomainAdvice http://.slashdot.org
> domains[0] = ..slashdot.org
> domains[1] = .slashdot.org
>
> Going with domains[0] would not the correct domain, while [1] is.
>
> When domains[0] was used you could never have a "foo.org" with a Advice,
> only ".foo.org".  In konq's cookie settings you can specify "foo.org".

Looks good indeed, but see below. It's a bit strange that this call actually 
takes a URL instead of just the string ".slashdot.org". 

As for returning Dunno instead of the global policy, the function currently 
reflects the actual setting for the domain specified and _only_ the domain 
specified.

On the other hand, if the call is supposed to return what would happen with a 
cookie from a certain url, then a lot more is needed as Dawit pointed out, 
and the loop from KCookieJar::cookieAdvice would need to be added.

Unfortunately this function is rather undocumented and it doesn't actually 
seem to be used by any code in CVS, so it's not really clear what it is 
supposed to do. Suggestions are welcome.

Cheers,
Waldo
-- 
bastian@kde.org  |  Wanted: Talented KDE developer  |  bastian@suse.com
  http://www.suse.de/de/company/suse/jobs/suse_pbu/developer_kde.html

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]