[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kioslave/http/kcookiejar
From:       "Dawit A." <adawit () kde ! org>
Date:       2004-10-03 22:43:23
Message-ID: 200410031843.24228.adawit () kde ! org
[Download RAW message or body]

On Sunday 03 October 2004 14:48, Benjamin Meyer wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> If you called
> dcop kcookiejar kcookiejar getDomainAdvice http://www.slashdot.org
> domains[0] = .slashdot.org
> domains[1] = slashdot.org
>
> The best example:
> dcop kcookiejar kcookiejar getDomainAdvice http://.slashdot.org
> domains[0] = ..slashdot.org
> domains[1] = .slashdot.org

IMHO that is a bogus example. Why would a user type "http://.slashdot.org" ? 
And even if we want to deal with that, then KCookieJar::extractDomains is the 
proper place for that...

> Going with domains[0] would not the correct domain, while [1] is.
>
> When domains[0] was used you could never have a "foo.org" with a Advice,
> only ".foo.org".  In konq's cookie settings you can specify "foo.org".

Valid point but that shows getDomainAdvice is currently broken. Why did you 
then find it necessary to change setDomainAdvice ? Moreover, your fix is as 
wrong as what was there in the first place. ::getDomainAdvice should iterate 
over all possible domains/hosts and return the appropriate result. Just 
changing it to domains[1] does not really solve anything...

-- 
Regards,
Dawit A.
"Preach what you practice, practice what you preach"
[prev in list] [next in list] [prev in thread] [next in thread]