[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kioslave/http/kcookiejar
From:       Benjamin Meyer <ben () meyerhome ! net>
Date:       2004-10-03 18:48:54
Message-ID: 200410031448.59023.ben () meyerhome ! net
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

If you called
dcop kcookiejar kcookiejar getDomainAdvice http://www.slashdot.org
domains[0] = .slashdot.org
domains[1] = slashdot.org

The best example:
dcop kcookiejar kcookiejar getDomainAdvice http://.slashdot.org
domains[0] = ..slashdot.org
domains[1] = .slashdot.org

Going with domains[0] would not the correct domain, while [1] is.

When domains[0] was used you could never have a "foo.org" with a Advice, only 
".foo.org".  In konq's cookie settings you can specify "foo.org".

- -Benjamin Meyer

On Sunday 03 October 2004 10:19 am, you wrote:
> Would you be so kind to explain what the "annoying bug" is and why this is
> the correct fix for it?
>
> Cheers,
> Waldo
>
> On Sunday 03 October 2004 10:42, Benjamin Meyer wrote:
> > CVS commit by bmeyer:
> >
> > Anoying bug that sucked up a few hours of my life
> >
> >
> >   M +3 -3      kcookieserver.cpp   1.53
> >
> >
> > --- kdelibs/kioslave/http/kcookiejar/kcookieserver.cpp  #1.52:1.53
> > @@ -560,5 +560,5 @@ KCookieServer::setDomainAdvice(QString u
> >        QStringList domains;
> >        mCookieJar->extractDomains(fqdn, domains);
> > -      mCookieJar->setDomainAdvice(domains[0],
> > +      mCookieJar->setDomainAdvice(domains[1],
> >                                    KCookieJar::strToAdvice(advice));
> >     }
> > @@ -576,5 +576,5 @@ KCookieServer::getDomainAdvice(QString u
> >        QStringList domains;
> >        mCookieJar->extractDomains(fqdn, domains);
> > -      advice = mCookieJar->getDomainAdvice(domains[0]);
> > +      advice = mCookieJar->getDomainAdvice(domains[1]);
> >     }
> >     return KCookieJar::adviceToStr(advice);

- -- 
aka icefox
Public Key: http://www.csh.rit.edu/~benjamin/public_key.asc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBYEmY1rZ3LTw38vIRAtiwAJ4sV599vjsNAcMRt7ZZy53utfgo2ACdEnc9
W/65eWuseXrPLcvr+nrbJHw=
=mpd4
-----END PGP SIGNATURE-----
[prev in list] [next in list] [prev in thread] [next in thread]