[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [patch] unfix for double-click between two words does not selecting
From:       Leo Savernik <l.savernik () aon ! at>
Date:       2004-10-01 12:40:38
Message-ID: 200410011440.45251.l.savernik () aon ! at
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


Hello,

For KDE 3.3, I fixed double-clicking between two words to not select both 
words.

However, apparently people have regarded this as a feature[1]. The resulting 
discussion on kde-usability showed that the "bug" should be reintroduced[2], 
thus effectively making it favoured behaviour.

The attached patch restores the behaviour of KDE 3.2 and earlier. I'll commit 
(and backport) this evening (to have it in KDE 3.3.1) if nobody complains.

mfg
 Leo

[1] http://lists.kde.org/?l=kde-usability&m=109545986215508&w=2
[2] http://lists.kde.org/?l=kde-usability&m=109549501732603&w=2


["khtml_selection_23.diff" (text/x-diff)]

Index: khtml_part.cpp
===================================================================
RCS file: /home/kde/kdelibs/khtml/khtml_part.cpp,v
retrieving revision 1.1023
diff -u -p -r1.1023 khtml_part.cpp
--- khtml_part.cpp	11 Sep 2004 00:08:57 -0000	1.1023
+++ khtml_part.cpp	1 Oct 2004 09:10:26 -0000
@@ -5662,8 +5662,6 @@ void KHTMLPart::extendSelection( DOM::No
 
   QString str;
   int len = 0;
-  // make offset point left to current char
-  if (right && offset > 0) offset--;
   if ( obj->isText() ) { // can be false e.g. when double-clicking on a disabled submit button
     str = static_cast<khtml::RenderText *>(obj)->data().string();
     len = str.length();

[Attachment #6 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]