[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdegraphics/kpdf/kpdf [POSSIBLY UNSAFE]
From:       Waldo Bastian <bastian () kde ! org>
Date:       2004-09-14 11:35:31
Message-ID: 200409141335.35426.bastian () kde ! org
[Download RAW message or body]


On Tuesday 14 September 2004 00:20, Albert Astals Cid wrote:
> CVS commit by aacid:
>
> Commiting first work on getting links to work.
> ATM only links to web pages are tested, i would like to get pdf with some
> weird links like the one that quits the app viewing it, or links to
> external files, etc so i can test them.
>
>   M +26 -25    kpdf_pagewidget.cc   1.38
>   M +240 -70   kpdf_part.cpp   1.78 [POSSIBLY UNSAFE: system]
>   M +2 -2      kpdf_part.h   1.35

I have strong doubts about this system() call in there. Can you elaborate on 
what it is supposed to do? If this is just about launching external links, 
can't you use KRun for those? Make sure to call 
KRun::setRunExecutables(false) in that case.

Cheers,
Waldo
-- 
bastian@kde.org  |   Novell BrainShare Europe 2004   |  bastian@suse.com
bastian@kde.org  | 12-18 September, Barcelona, Spain |  bastian@suse.com

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]