[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdegraphics/kpdf
From:       André_Wöbbeking <Woebbeking () web ! de>
Date:       2004-08-25 20:21:07
Message-ID: 200408252221.07770.Woebbeking () web ! de
[Download RAW message or body]

On Wednesday 25 August 2004 22:03, Albert Astals Cid wrote:
> Hi :)
>
> Are you sure the top_srcdir thing is necessary?
>
> Here is what Stephan Kulow says about it
>
> "
> relative paths are always better than absolute paths as they allow
> relocation of subtrees. Files in source dir have to be relative to
> $(srcdir) and files in build dir are relative to '.'. $(top_*dir) should
> only be used to access intermodule dependencies - definitely not files in
> subdirs.
> "

If coolo says so. I find the -I$(srcdir)/../goo a bit strange.

> So the #include "../config.h" change is problably good, but as top_srcdir
> is not recommended by "the boss" can you try changing
> -I.. to $(srcdir) instead of to -I$(top_srcdir)/kpdf and see if it works?

must be -I$(srcdir)/.. then. OK, will do so.


André

[prev in list] [next in list] [prev in thread] [next in thread]