[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdenonbeta/icecream/icecream/services [POSSIBLY UNSAFE]
From:       Michael Matz <matz () kde ! org>
Date:       2004-08-22 12:36:34
Message-ID: 20040822123634.43CD42737 () office ! kde ! org
[Download RAW message or body]

CVS commit by matz: 

Better.


  M +5 -4      scheduler.cpp   1.147 [POSSIBLY UNSAFE: printf]


--- kdenonbeta/icecream/icecream/services/scheduler.cpp  #1.146:1.147
@@ -1064,12 +1064,13 @@ handle_line (MsgChannel *c, Msg *_m)
           int id = it->first;
           Job *job = it->second;
-          sprintf (buffer, "%d %s sub:%s on:%s ",
+          snprintf (buffer, sizeof (buffer), "%d %s sub:%s on:%s ",
                    id,
-                   job->submitter ? job->submitter->nodename.c_str() : "<>",
-                   job->server ? job->server->nodename.c_str() : "<unknown>",
                    job->state == Job::PENDING ? "PEND"
                      : job->state == Job::WAITINGFORCS ? "WAIT"
                      : job->state == Job::COMPILING ? "COMP"
-                     : "Huh?");
+                     : "Huh?",
+                   job->submitter ? job->submitter->nodename.c_str() : "<>",
+                   job->server ? job->server->nodename.c_str() : "<unknown>");
+          buffer[sizeof (buffer) - 1] = 0;
           line = buffer;
           line = line + job->filename;


[prev in list] [next in list] [prev in thread] [next in thread]