[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdepim
From:       Reinhold Kainhofer <reinhold () kainhofer ! com>
Date:       2004-08-19 1:26:40
Message-ID: 20040819012640.77EE799A8 () office ! kde ! org
[Download RAW message or body]

CVS commit by kainhofe: 

Move all methods that return some kind of textual representation of incidences to a \
helper class IncidenceFormatter, which has several static methods for incidence tool \
tips, (pure text) mail bodys for invitations, html representations of invitations \
(for kmail's bodypart formatter), and for showing a rich-text version in the event \
viewer.

I also completely rewrote the formatICal method, which is used by kmail's bodypart \
formatter, since the old version was parsing the invitation as an iCalendar file \
(which completely disregards all group scheduling fields like the method), and then \
needed to parse the mail a second time to find the method. This can be easier done by \
the parseScheduleMessage. Also, there were so many places, which explicitely checked \
incidence->type()=="Event". I changed all these to visitors, so there are now about \
six different visitors used by the IncidenceFormatter. The way to get the URL for the \
links is implemented via a helper class. See the bodypartformatter, or the formatICal \
DCOP method of korganizer (which I don't want to remove, because korganizer was \
released with this DCOP method, and applications removing dcop functions can be \
really a pain as we experienced with kpilot. So I won't do it myself now with \
korganizer...)

If anything (in particular kmail's body part formatter for invitations) breaks by \
this commit, please drop me an email (or directly confront me at aKademy).

CCMAIL: kde-pim@kde.org


  A            libkcal/incidenceformatter.cpp   1.1 [LGPL (v2+)]
  A            libkcal/incidenceformatter.h   1.1 [LGPL (v2+)]
  M +0 -2      korganizer/Makefile.am   1.277
  M +3 -270    korganizer/koeventviewer.cpp   1.52
  M +0 -23     korganizer/koeventviewer.h   1.24
  M +15 -755   korganizer/kogroupware.cpp   1.36
  M +1 -1      korganizer/kogroupware.h   1.13
  M +2 -117    korganizer/koincidencetooltip.cpp   1.7
  M +0 -32     korganizer/koincidencetooltip.h   1.3
  M +3 -3      korganizer/kolistview.cpp   1.79
  M +4 -131    korganizer/komailclient.cpp   1.52
  M +0 -2      korganizer/komailclient.h   1.23
  M +3 -3      korganizer/komonthview.cpp   1.107
  M +3 -3      korganizer/kotodoview.cpp   1.171
  M +4 -1      libkcal/Makefile.am   1.53
  M +11 -2     libkcal/icalformat.cpp   1.62
  M +13 -362   plugins/kmail/bodypartformatter/text_calendar.cpp   1.23


[prev in list] [next in list] [prev in thread] [next in thread]