[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdenonbeta/ktetrinet/ktetrinet
From:       Albert Astals Cid <astals11 () terra ! es>
Date:       2004-07-25 9:31:44
Message-ID: 200407251131.44396.astals11 () terra ! es
[Download RAW message or body]

I was told that using relative paths in Makefile.am is bad for people that 
uses build dir != source dir so i substituted them by using $(top_srcdir), 
then Matt Rogers (i think that's mattr on IRC) told me that if the .a is 
generated during compilation i should not use $(top_srcdir) but 
$(top_builddir), so i changed them again see 

http://lists.kde.org/?l=kde-cvs&m=109069746329032&w=2

If that is the same as using how it was before please tell me and i'll go back 
to the ./net/libnet.a

Albert

A Dissabte 24 Juliol 2004 23:40, Stephan Kulow va escriure:
> Am Samstag 24 Juli 2004 21:26 schrieb Albert Astals Cid:
> > CVS commit by aacid:
> >
> > Better makefiles
> >
> > @@ -4,7 +4,9 @@
> >
> >  ktetrinet_SOURCES = ktetrinet.cpp main.cpp settings.kcfgc mysettings.cpp
> > -ktetrinet_LDADD   =  ./net/libnet.a ./dialogs/libdialogs.a \
> > -                     ./widgets/libwidgets.a ./helpers/libhelpers.a \
> > -                      $(LIB_KDEUI)
> > +ktetrinet_LDADD   = $(top_srcdir)/ktetrinet/ktetrinet/net/libnet.a \
> > +                $(top_srcdir)/ktetrinet/ktetrinet//dialogs/libdialogs.a
> > \ +               
> > $(top_srcdir)/ktetrinet/ktetrinet//widgets/libwidgets.a \ +              
> >  $(top_srcdir)/ktetrinet/ktetrinet//helpers/libhelpers.a \ +             
> >   $(LIB_KDEUI)
>
> What makes that better? Is that the american meaning of the word better aka
> bigger makefiles? I can't see an improvement otherwise.
>
> Greetings, Stephan
[prev in list] [next in list] [prev in thread] [next in thread]