[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE_3_2_BRANCH: kdelibs/kdeui
From:       Nicolas Goutte <nicolasg () snafu ! de>
Date:       2004-07-20 14:22:08
Message-ID: 200407201622.09436.nicolasg () snafu ! de
[Download RAW message or body]

Now I have understood! The patch works but SuSE 9.0 ' rgb.txt has many colours 
that are untranslatted. But with the xx language, the translated coulours are 
far back in alphabetical order, so that you have to scroll nearly down to see 
the first translated colours. (Seeing so many untranslated coulours, i did 
not do so first and have not even seen that some colours had high numbers but 
not the low ones (which are translated.)

So I am going to apply the patch. Not sure what to do with the other coulours 
however,

Have a nice day!

On Tuesday 20 July 2004 15:48, Nicolas Goutte wrote:
> On Sunday 18 July 2004 22:10, David Faure wrote:
> > On Sunday 18 July 2004 21:59, Nicolas Goutte wrote:
> > > On Sunday 18 July 2004 21:50, David Faure wrote:
> > > > On Sunday 18 July 2004 21:44, Nicolas Goutte wrote:
> > > > > Well, if the translation does not work, it must come from somewhere
> > > > > (*)
> > > >
> > > > Well how does the contents of rgb.txt end up in a .pot file? And which
> > > > one?
> > >
> > > The template is kdelibs_colors.pot (in kdelibs). From where it is
> > > extracted, I do not know, but the template seems right.
> >
> > But I'm not sure the .mo file is loaded correctly. Hmm I'm sure it's not.
> > It's only loaded for 8-bit displays (!). Please try this patch.
> 
> I have compile kdlibs and kdebase CVS HEAD and the xx languages, applied the 
> patch, but it still does not work. (And it seems that there are more 
> untranslated strings in the color dialog, but that is another problem.)
> 
> That has been my first test, I have not cross-checked anything, except that 
> the colors are really translated in xx.
> 
> (I have tested with KDE_LANG=xx kate ,while using the color settings of 
Kate.)
> 
> Have a nice day!
> 
> >
> > Index: kcolordialog.cpp
> > ===================================================================
> > RCS file: /home/kde/kdelibs/kdeui/kcolordialog.cpp,v
> > retrieving revision 1.115
> > diff -u -p -r1.115 kcolordialog.cpp
> > --- kcolordialog.cpp    13 Mar 2004 13:56:19 -0000      1.115
> > +++ kcolordialog.cpp    18 Jul 2004 20:09:03 -0000
> > @@ -188,8 +188,6 @@ static void createStandardPalette()
> >      standardPalette[i++] = Qt::gray;
> >      standardPalette[i++] = Qt::darkGray;
> >      standardPalette[i++] = Qt::black;
> > -
> > -    KGlobal::locale()->insertCatalogue("kdelibs_colors");
> >  }
> >
> >
> > @@ -620,6 +618,8 @@ KPaletteTable::readNamedColor( void )
> >      return; // Strings already present
> >    }
> >
> > +  KGlobal::locale()->insertCatalogue("kdelibs_colors");
> > +
> >    //
> >    // Code somewhat inspired by KPalette.
> >    //
> >
> > > But it is the user's rgb.txt file which is used.
> >
> > So there could be discrepancies. Is the bug that _some_ colors aren't
> > translated, or that all of them aren't?
> 
> 

[prev in list] [next in list] [prev in thread] [next in thread]