[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE_3_2_BRANCH: kdelibs/kdeui
From:       David Faure <faure () kde ! org>
Date:       2004-07-18 20:10:14
Message-ID: 200407182210.15316.faure () kde ! org
[Download RAW message or body]

On Sunday 18 July 2004 21:59, Nicolas Goutte wrote:
> On Sunday 18 July 2004 21:50, David Faure wrote:
> > On Sunday 18 July 2004 21:44, Nicolas Goutte wrote:
> > > Well, if the translation does not work, it must come from somewhere (*)
> >
> > Well how does the contents of rgb.txt end up in a .pot file? And which one?
> 
> The template is kdelibs_colors.pot (in kdelibs). From where it is extracted, I 
> do not know, but the template seems right.

But I'm not sure the .mo file is loaded correctly. Hmm I'm sure it's not. It's only
loaded for 8-bit displays (!). Please try this patch.

Index: kcolordialog.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdeui/kcolordialog.cpp,v
retrieving revision 1.115
diff -u -p -r1.115 kcolordialog.cpp
--- kcolordialog.cpp    13 Mar 2004 13:56:19 -0000      1.115
+++ kcolordialog.cpp    18 Jul 2004 20:09:03 -0000
@@ -188,8 +188,6 @@ static void createStandardPalette()
     standardPalette[i++] = Qt::gray;
     standardPalette[i++] = Qt::darkGray;
     standardPalette[i++] = Qt::black;
-
-    KGlobal::locale()->insertCatalogue("kdelibs_colors");
 }


@@ -620,6 +618,8 @@ KPaletteTable::readNamedColor( void )
     return; // Strings already present
   }

+  KGlobal::locale()->insertCatalogue("kdelibs_colors");
+
   //
   // Code somewhat inspired by KPalette.
   //


> But it is the user's rgb.txt file which is used.
So there could be discrepancies. Is the bug that _some_ colors aren't translated,
or that all of them aren't? 

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]