[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE_3_2_BRANCH: kdelibs/kdeui
From:       David Faure <faure () kde ! org>
Date:       2004-07-18 19:30:16
Message-ID: 200407182130.17160.faure () kde ! org
[Download RAW message or body]

On Sunday 18 July 2004 21:26, Nicolas Goutte wrote:
> CVS commit by goutte: 
> 
> i18n() works with UTF-8 not ISO-8859-1
> (Can somebody port it to KDE CVS HEAD please?)
> 
> 
>   M +1 -1      kcolordialog.cpp   1.114.2.1
> 
> 
> --- kdelibs/kdeui/kcolordialog.cpp  #1.114:1.114.2.1
> @@ -653,5 +653,5 @@ KPaletteTable::readNamedColor( void )
>            continue;
>          }
> -        list.append( i18n("color", name.latin1() ) );
> +        list.append( i18n("color", name.utf8() ) );
>        }
>      }

Have you ever seen anything else than latin1 characters in /usr/X11R6/lib/X11/rgb.txt ??
Your change makes the code slower for no benefit, I'm afraid.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]