[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/lib/store
From:       David Faure <faure () kde ! org>
Date:       2004-07-16 23:19:42
Message-ID: 200407170119.42971.faure () kde ! org
[Download RAW message or body]

On Saturday 17 July 2004 01:09, Nicolas Goutte wrote:
> CVS commit by goutte: 
> 
> If the KWord 1.3 import filter should use KoXmlWriter, I need a function
> for correctly handling spans, as the direct writes are private to the class.
> 
> (This can perhaps be optimized, perhaps be merged with addTextNode,
> perhaps be... I do not know... Future will tell!)

I have a more recent version and cleaner version of this code in  KoTextParag::writeSpanText  (kotext).
Do you agree with (you or me) updating KoXmlWriter to that code?

Also, I realize that we keep adding oasis-specific stuff to koxmlwriter (I was the first one),
which is bad design (the basic class was generic enough to be used in other circumstances).
Maybe we should have a KoOasisXmlWriter derived class, but that's a bit long and
requires changing the API everywhere. Another idea would be KoXmlWriterBase...
Ah well, no big deal there, can always be done later when needed.
Let's concentrate on writeSpanText for now :)

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]