[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kde-common/admin
From:       Adriaan de Groot <adridg () cs ! kun ! nl>
Date:       2004-07-13 9:26:43
Message-ID: Pine.GSO.4.44.0407131124570.12942-100000 () odin ! cs ! kun ! nl
[Download RAW message or body]

On Tue, 13 Jul 2004, Nicolas Goutte wrote:

> On Tuesday 13 July 2004 10:50, Adriaan de Groot wrote:
> > CVS commit by adridg:
> >
> > Don't use ==, it's not a test(1) operator; quote '' the unequal stuff just
> > in case of history substitution.
>
> Is this quoting really need (or to what extend)? If yes, then there are many
> tests in KDE...

No, the quoting probably isn't necessary - othewise we'd have heard about
it already. /bin/sh doesn't do history substitution, and bash invoked as
/bin/sh doesn't either. I;m just personally anxious about a ! anywhere in
a command line. Take those quotes out if you feel it bloats admin.


[prev in list] [next in list] [prev in thread] [next in thread]