[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/konqueror
From:       Michael Brade <brade () kde ! org>
Date:       2004-06-30 11:11:08
Message-ID: 200406301311.12317.brade () kde ! org
[Download RAW message or body]


On Tuesday 29 June 2004 12:32, David Faure wrote:
> So can you double-check that commit?
Yes, it's perfectly ok. Excellent idea to do it via KDirLister, I guess it 
would have taken me quite a bit to realize that a file has to change before 
the bug actually appears.... :-)

> Isn't there a better way to find out 
> that a subdir was deleted, to differ that from a hidden file? iirc we have
> a dict of subdirs.
Hmm, I don't understand your thinking... subdir or not is only important in 
the treeview, and you didn't fix that yet ;) 

The comment you added is true, but, frankly, pretty useless. slotDeleteItem() 
is called for every removed item and the isUpdatesEnabled() check is 
necessary because in case of deletion of the root item setComplete() is not 
called (which usually does the isUpdatesEnabled() check). Can't remember why 
though; neither why or if there isn't a better way.

> > Aha! Reminds me of a similar case on my TODOs: when a hidden file gets
> > changed the 16 TB or so bug appears as well. Have you fixed both cases
> > with your last commit?
>
> Yes. No such bug can happen anymore, since we now iterate over the
> (non-filtered-out) items in the dirlister to calculate the totals.
Thanks heaps :-)

-- 
Michael Brade;                 KDE Developer, Student of Computer Science
  |-mail: echo brade !#|tr -d "c oh"|s\e\d 's/e/\@/2;s/$/.org/;s/bra/k/2'
   °--web: http://www.kde.org/people/michaelb.html

KDE 3: The Next Generation in Desktop Experience

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]