[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE_3_2_BRANCH: kdelibs/kate/part
From:       Nicolas Goutte <nicolasg () snafu ! de>
Date:       2004-06-28 15:09:10
Message-ID: 200406281709.10733.nicolasg () snafu ! de
[Download RAW message or body]

>List:       kde-cvs
>Subject:    Re: KDE_3_2_BRANCH: kdelibs/kate/part
> From:       David Faure <faure () kde ! org>
>Date:       2004-06-28 14:58:09
>Message-ID: <200406281658.10466.faure () kde ! org>

>On Monday 28 June 2004 16:52, Nicolas Goutte wrote:
>> >List:       kde-cvs
>> >Subject:    KDE_3_2_BRANCH: kdelibs/kate/part
>> > From:       David Faure <faure () kde ! org>
>> >Date:       2004-06-28 14:17:36
>> >Message-ID: <20040628141736.80D819976 () office ! kde ! org>
>> >
>> >CVS commit by faure: 
>> >
>> >Backport fix for #57623: kioslave:ftp uses binary mode to get files
>> >CCMAIL: 57623-done@bugs.kde.org
>> 
>> Are you sure that you can do it?
>> 
>> What happens when loading UTF-16 and that you have the character 0x0d0a , 
>> would it not be considered as CR/LF and transformed to LF, resulting in a 
>bad 
>> UTF-16 file? (And 0x0a0d if the UTF-16 is of the other endian or any 
>similar 
>> sequence of bytes made from 2 characters)
>
>Who says this has anything to do with UTF-16?

Well, as far as I can see you are modifing unconditionally Kate's code. Kate 
can load UTF-16 files too, as far as I know. So my first feeling is that your 
change breaks UTF-16. (As I do not really know Kate's code, I am not sure if 
it is really matters or not.)

>
>I thought that report was only about using the FTP text ("ascii") mode 
>instead of the binary mode for text files,

>I see no mention of UTF16 in the report.
I do not mean the report, I mean the ability to still use UTF-16.

>

Have a nice day!

[prev in list] [next in list] [prev in thread] [next in thread]