[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdebase/konqueror/keditbookmarks
From:       Toivo Pedaste <toivo () ucs ! uwa ! edu ! au>
Date:       2004-06-24 14:56:04
Message-ID: 20040624145604.CC27B995B () office ! kde ! org
[Download RAW message or body]

CVS commit by toivo: 

Fix status display


  M +17 -13    testlink.cpp   1.30


--- kdebase/konqueror/keditbookmarks/testlink.cpp  #1.29:1.30
@@ -198,7 +198,8 @@ QString TestLinkItrHolder::calcPaintStyl
     }
 
-    // get new mod date if there is one
+    // get new mod time if there is one
     newModStr = self()->getMod(url);
 
+    // if no new mod time use previous one
     if (newModStr.isNull()) {
         newModStr = Modify;
@@ -243,23 +244,25 @@ QString TestLinkItrHolder::calcPaintStyl
 
     if (!newModStr.isNull() && !newModValid) { 
-        // error in current check
+        // Current check has error
         statusStr = newModStr;
-//      kdDebug() << "=======================Bold=" << visit << "\n";
-        style = (!oldError) 
-            ? KEBListViewItem::DefaultStyle : KEBListViewItem::BoldStyle;
-
-    } else if (initial && !newModStr.isNull() && (newMod == 0)) { 
-        // initial display and no modify time recorded
-        statusStr = QString::null;
+        if (oldError) {
+            style = KEBListViewItem::BoldStyle;
+        } else {
+            style =  KEBListViewItem::DefaultStyle;
+        }
 
     } else if (initial && oldError) { 
-        // error in previous check
+        // Previous check has error
         style = KEBListViewItem::GreyStyle;
-        statusStr = i18n("Error");
+        statusStr = i18n("Error ");
 
-    } else if (!newModStr.isNull() && (newMod == 0)) { 
-        // no modify time returned
+    } else if (!initial && !newModStr.isNull() && (newMod == 0)) { 
+        // Current check has no modify time
         statusStr = i18n("Ok");
 
+    } else if (initial && !newModStr.isNull() && (newMod == 0)) { 
+        // previous check has no modify time recorded
+        statusStr = QString::null;
+
     } else if (!newModStr.isNull() && (newMod > visit)) { 
         // if modify time greater than last visit, show bold modify time
@@ -312,4 +315,5 @@ static void parseNsInfo(const QString &n
 }
 
+// Still use nsinfo for storing old modify time
 static const QString updateNsInfoMod(const QString &_nsinfo, const QString &nm) {
     QString nCreate, nAccess, nModify;


[prev in list] [next in list] [prev in thread] [next in thread]