[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdepim/libkdenetwork/gpgmepp
From:       David Faure <faure () kde ! org>
Date:       2004-06-23 18:44:40
Message-ID: 200406232044.41371.faure () kde ! org
[Download RAW message or body]

On Wednesday 23 June 2004 19:15, Marc Mutz wrote:
> On Tuesday 22 June 2004 19:48, Lauri Watts wrote:
> <snip>
> > Make it compile nicely on FreeBSD 4.x
> <snip>
> > --- kdepim/libkdenetwork/gpgmepp/key.h  #1.9:1.10
> > @@ -22,7 +22,22 @@
> >  #define __GPGMEPP_KEY_H__
> >
> > +#ifdef HAVE_CONFIG_H
> > +#include "config.h"
> > +#endif
> > +
> >  #include <gpgmepp/gpgmefw.h>
> >  #include <gpgmepp/context.h>
> >
> > +#ifdef TIME_WITH_SYS_TIME
> > +# include <sys/time.h>
> > +# include <time.h>
> > +#else
> > +# ifdef HAVE_SYS_TIME_H
> > +#  include <sys/time.h>
> > +# else
> > +#  include <time.h>
> > +# endif
> > +#endif
> > +
> >  #include <vector>
> <snip>
> 
> Sorry, this is wrong. There can't be a config.h include in a header 
> file, since config.h won't be there anymore if it was installed (and 
> these are installed).
> 
> Googling around, I found no real solution, but it seems that if you just 
> want time_t defined, you can get away with only:
>  #include <sys/types.h>
>  #include <time.h>

Yep, this is what we do in e.g. kdecore/krfcdate.h too, and it seems to be enough.
I think the whole TIME_WITH_SYS_TIME stuff is very old and not needed anymore.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]