[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdesdk/kompare/libdiff2
From:       bruggie () bruggie ! net
Date:       2004-06-21 20:20:24
Message-ID: 1087849224.40d74308118d8 () bruggie ! dnsalias ! org
[Download RAW message or body]

Quoting David Faure <faure@kde.org>:
> CVS commit by faure: 
> 
> Don't crash if setEncoding wasn't called - which seems to be the case in
> komparepart.
> Testcase: Stefan Teleman's "patch for arts" mail on kde-core-devel. Click on
> diff.bz2
> attachment, opens in ark, RMB / View. Kompare can't parse that diff, but at
> least
> doesn't crash anymore
> CCMAIL: Otto Bruggeman <ottobruggeman@kde.nl>

Thanks for the fix ! I'll have to think this through, i never considered the
fact that the komparepart can be used in other apps where i do not set the
encoding from the outside. I guess i'll have to use some form of autodetection
if possible.

And I should probably fix the parser to detect this format and emit an error
message saying that this format is not supported... too bad i missed the
message freeze, this will have to wait until 4.0 then i guess.

Thanks again,
Otto

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.
[prev in list] [next in list] [prev in thread] [next in thread]