[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdebase/konqueror/iconview
From:       Enrico Ros <rosenric () dei ! unipd ! it>
Date:       2004-06-06 13:52:37
Message-ID: 20040606135237.C403A126CE () office ! kde ! org
[Download RAW message or body]

CVS commit by eros: 

Optimize #9b. '--unwantedRepaints;' If a preview job is running over the
iconview, stop it without repainting (the repaint will be done by
arrangeItemsInGrid() on the line below).


  M +12 -2     konq_iconview.cc   1.463


--- kdebase/konqueror/iconview/konq_iconview.cc  #1.462:1.463
@@ -675,9 +675,19 @@ void KonqKfmIconView::newIconSize( int s
         return;
 
+    // Stop a possible preview job taking care of disabling updates
+    // or else the view will be repainted immediately
+    if ( m_pProps->isShowingPreview() )
+    {
+        m_pIconView->setUpdatesEnabled( false );
+        m_pIconView->stopImagePreview();
+        m_pIconView->setUpdatesEnabled( true );
+    }
+
+    // Set icons size, arrage items in grid and repaint the whole view
     m_pIconView->setIcons( size );
+
+    // If previews are enabled start a new job
     if ( m_pProps->isShowingPreview() )
         m_pIconView->startImagePreview( m_pProps->previewSettings(), true );
-    // arrangeItemsInGrid already done in KonqIconViewWidget::setIcons
-    //m_pIconView->arrangeItemsInGrid();
 }
 


[prev in list] [next in list] [prev in thread] [next in thread]