[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kabc
From:       David Faure <faure () kde ! org>
Date:       2004-06-03 11:30:35
Message-ID: 200406031330.35664.faure () kde ! org
[Download RAW message or body]

On Thursday 03 June 2004 13:25, Zack Rusin wrote:
> CVS commit by zrusin: 
> 
> avoid detaching
> 
> 
> M +1 -1      formatfactory.cpp   1.8
> 
> 
> --- kdelibs/kabc/formatfactory.cpp  #1.7:1.8
> @@ -58,5 +58,5 @@ FormatFactory::FormatFactory()
> 
> QStringList list = KGlobal::dirs()->findAllResources( "data" \
>                 ,"kabc/formats/*.desktop", true, true );
> -  for ( QStringList::iterator it = list.begin(); it != list.end(); ++it )
> +  for ( QStringList::ConstIterator it = list.begin(); it != list.end(); ++it )

Actually, to really avoid detaching, Simon says(*) you should use
const QStringList list = ....

(*) no this isn't 'Die Hard' :)

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).


[prev in list] [next in list] [prev in thread] [next in thread]