[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdepim/certmanager
From:       Marc Mutz <Marc.Mutz () uni-bielefeld ! de>
Date:       2004-06-01 16:57:24
Message-ID: 20040601165724.83462126E6 () office ! kde ! org
[Download RAW message or body]

CVS commit by mutz: 

Don't crash.

Plugging in the LineEditAction sets the QLineEdit* in that action,
the following createGUI() deletes the searchToolBar to re-create it again,
the pointer in the action becomes dangling, the setText() call crashes.

Fix suggested by dfaure.


  M +1 -6      certmanager.cpp   1.102


--- kdepim/certmanager/certmanager.cpp  #1.101:1.102
@@ -333,12 +333,9 @@ void CertManager::createActions() {
   if (KStandardDirs::findExe("kwatchgnupg").isEmpty()) action->setEnabled(false);
 
-  // Toolbar
-  KToolBar * _toolbar = toolBar( "searchToolBar" );
+  (void)new LabelAction( i18n("Search:"), actionCollection(), "label_action" );
 
-  (new LabelAction( i18n("Search:"), actionCollection(), "label_action"))->plug( _toolbar );
   mLineEditAction = new LineEditAction( QString::null, actionCollection(), this,
                                         SLOT(slotSearch()),
                                         "query_lineedit_action");
-  mLineEditAction->plug( _toolbar );
 
   QStringList lst;
@@ -346,9 +343,7 @@ void CertManager::createActions() {
   mComboAction = new ComboAction( lst, actionCollection(), this, SLOT( slotToggleRemote(int) ),
                                   "location_combo_action");
-  mComboAction->plug( _toolbar );
 
   mFindAction = new KAction( i18n("Find"), "find", 0, this, SLOT(slotSearch()),
                              actionCollection(), "find" );
-  mFindAction->plug( _toolbar );
 
   KStdAction::keyBindings( this, SLOT(slotEditKeybindings()), actionCollection() );


[prev in list] [next in list] [prev in thread] [next in thread]