[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdeedu/keduca
From:       Klas =?utf-8?q?Kala=C3=9F?= <klas.kalass () gmx ! de>
Date:       2004-05-14 15:03:14
Message-ID: 200405141703.19463.klas.kalass () gmx ! de
[Download RAW message or body]


Hi Anma,
thanks for having a look at KEduca. 

Removing delete _mainview is the correct fix, you just introduced a memleak 
(close one file and open another...). Please revert. What is it you were 
trying to fix? Can you send me a backtrace?

Am Freitag, 14. Mai 2004 16:34 schrieb Anne-Marie Mahfouf:
> CVS commit by annma:
>
> I think I fixed bug 80486 - some delete _mainview cause crashes
> Besides the File ->close() and File -> quit() are not so good, Close should
> be disabled when no file is loaded. In fact, is File-> Close needed at all
> as there is only one view??? CCMAIL=80486-done@bugs.kde.org
> CCMAIL=javi@asyris.org
> CCMAIL=klas@kde.org
>
>
>   M +4 -3      keduca/keduca.cpp   1.22
>   M +5 -44     libkeduca/fileread.cpp   1.7

PS:
I know the documentation was duplicated from the header but I got a shock when 
I did a cvslastchange ... please mention things like that in the commit 
message as well.

PPS: I am sure Christian Wolfgang Hujer would have deserved to read his name 
in CVS log...


[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]