[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdepim/plugins/kmail/bodypartformatter
From:       Bo Thorsen <bo () sonofthor ! dk>
Date:       2004-05-12 18:59:48
Message-ID: 200405122101.21183.bo () sonofthor ! dk
[Download RAW message or body]


On Wednesday 12 May 2004 20:45, George Staikos wrote:
> What exactly is the purpose of this?  It's a race condition waiting to
> happen. I suggest using one of the standard mechanisms for creating a
> file.

No other reason than the fact that this was the code that was there 
already. I haven't tried to fix this code, just to make it work again.

The possibility of a race condition is purely theoretical here, but that 
doesn't mean I'm fond of this code. So if someone improves on it, fine by 
me.

Bo.

> On May 12, 2004 14:42, Bo Thorsen wrote:
> > CVS commit by thorsen:
> >
> > Whoops
> >
> >
> >   M +1 -1      text_calendar.cpp   1.14
> >
> >
> > --- kdepim/plugins/kmail/bodypartformatter/text_calendar.cpp 
> > #1.13:1.14 @@ -534,5 +534,5 @@ class UrlHandler : public
> > KMail::Interfa QString file;
> >        do {
> > -        file = location + KApplication::randomString( 10 );
> > +        file = location + "/" + KApplication::randomString( 10 );
> >        } while ( QFile::exists( file ) );
> >        QFile f( file );

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]