[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdeextragear-1/amarok/src
From:       Max Howell <max.howell () methylblue ! com>
Date:       2004-05-04 18:14:43
Message-ID: 20040504181443.B0A0E9A8A () office ! kde ! org
[Download RAW message or body]

CVS commit by mhowell: 

My modem broke, so I've not been able to commit for 2 weeks. This is 2 weeks work. \
The commit is a whopper! There is definately something for everyone here :-)

Screenie: http://methylblue.com/images/amarok_040503.png

* PlayerWindow is now optional, note the behavior for "dual window mode" is slightly \
regressed, somewhat due to the Q_Dialog flag I pass the PlayerWindow, suggestion to \
bug fixing crew: remove that flag! I also had to move some setXT() stuff to the \
*window class dtors to make this possible, and tweak some functions to prevent \
crashes, but thanks to Larson making the PlayerWindow nice and encapsulated, it was \
quite easy :) Also the PlaylistWindow is now always the main Window in terms of Qt \
                (ie parent to config dialog) as it is the only widget we know will \
                exist
* I put this dummyEngine thing in App::initEngine(), to replace the kdFatal() that \
was causing a crash. I'm not sure if it was still causing a crash in beta2 as markey \
                fixed some stuff. If it's of no use now, feel free to remove it.
* I removed the initPlayerWidget() and initPlayerWindow() functions from class App as \
                due to making PlayerWindow optional they had 3 loc between them!
* Fix bug where you get amarok scheme colors left over when you switch color scheme
* Much nicer kde scheme colouring for the current track etc.
* BrowserBar now is leaner and faster for resizes, I also made the API more friendly \
to newcomers, fixed a wierd race condition crash bug I found and improved it for \
                future maintanance.
* I added a clear button next to the main search lineEdit
* I added spacings and margins to all main UI widgets, I think it looks very nice \
now, especially in KDE scheme mode. That's how I use it now. I've said goodbye to \
amaroK blue! I also made the BrowserBar splitter vanish when the tabs are all shut \
                which is prettier I think.
* Fixed a bug in metaBundle prettyTitle()
* Nicer glow for kde scheme mode, try it and see! Glow is same as before for amaroK \
                scheme mode.
* Fixed bug with next/prev being disabled when they shouldn't be
* added little play icon next to first column text when playing that track
* F2 now works for editing tags! Woo! Also tab will go to the next tag.
* Set standard kde caption on Track Information dialog
* Fixed crash bug for remote playlist downloading. We now fetch audioproperties \
simultanesouly to other tags. I reckon fetching them on view is not much of a \
performance increase anyway. Also there was a huge performance drain I was keeping to \
myself that was hidden in that code... to do with searching for items being visible \
in big lists. The crash bug was caused by trying to get audioproperties for failed \
                downloads or slow download_markers.
* Fix bug. Use a KSqueezedText label in the statusbar so that amaroK doesn't suddenly \
                resize itself when you play a track with a big name!
* Some loc-down in the statusbar, enforce m_p prefix for m_progress as the rest were \
                like that
* Force fixed sizing to speed up repaints and make sure all items are the same height \
                for aesthetics.
* Pause makes statusbar time display flash, also temporary message "paused" is \
displayed, this makes the progress bar become a top-level widget! Somebody fix \
                please..
* Disable track-slider when paused/stopped
* Proper i18n of plurals in statusbar
* Make analyzers aware of paletteChanges and make ToolbarAnalyzer colorised based on \
kde color scheme. Looks great! Lots of code to ensure there is contrasting colouring \
:(

Finally I fear some regressions due to the recent source file renaming and the fact I \
cannot compile the sources on this computer (I'm at uni) and I had to do a lot of \
merging. Please forgive me..


  M +8 -0      Options1.ui   1.23
  M +111 -119  Options2.ui   1.22
  M +5 -1      actionclasses.cpp   1.27
  M +159 -130  app.cpp   1.309
  M +2 -4      app.h   1.132
  M +124 -142  browserbar.cpp   1.11
  M +28 -32    browserbar.h   1.4
  M +6 -3      collectionbrowser.cpp   1.81
  M +4 -0      filebrowser.cpp   1.19
  M +10 -4     metabundle.cpp   1.4
  M +1 -1      osd.cpp   1.24
  M +13 -4     playerwindow.cpp   1.142
  M +2 -1      playerwindow.h   1.61
  M +162 -27   playlist.cpp   1.182
  M +8 -7      playlist.h   1.76
  M +26 -12    playlistitem.cpp   1.77
  M +5 -0      playlistitem.h   1.40
  M +72 -23    playlistwindow.cpp   1.124
  M +5 -5      playlistwindow.h   1.54
  M +4 -4      searchbrowser.cpp   1.14
  M +135 -100  statusbar.cpp   1.16
  M +16 -16    statusbar.h   1.12
  M +18 -5     systray.cpp   1.26
  M +5 -0      amarokcore/amarok.kcfg   1.19
  M +15 -0     analyzers/analyzerbase.cpp   1.27
  M +1 -0      analyzers/analyzerbase.h   1.21
  M +4 -2      analyzers/analyzerfactory.cpp   1.20
  M +89 -36    analyzers/blockanalyzer.cpp   1.22
  M +3 -0      analyzers/blockanalyzer.h   1.13


[prev in list] [next in list] [prev in thread] [next in thread]