[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/kioslave/imap4
From:       George Staikos <staikos () kde ! org>
Date:       2004-04-03 16:05:59
Message-ID: 200404031105.59542.staikos () kde ! org
[Download RAW message or body]

On Saturday 03 April 2004 01:58, Marc Mutz wrote:
> On Friday 02 April 2004 19:56, George Staikos wrote:
> > -  _box = _box.left (_box.find (';')); // strip parameters
> > +  _box.truncate(_box.find (';')); // strip parameters
>
> Ugh. You rely on (uint)-1 > _box.length() here. Maybe there should be an
> explicit check for the find() result? Note also that
> Q_C_String::truncate( -1 )  isn't a no-op.
>
> (yes, the error was in the old code, too)

  Yup I noticed that but I  need to understand the code before I can properly 
fix it.  There are lots of other bugs in the parser too, if you're 
interested.  I marked some of them. :-)

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/
[prev in list] [next in list] [prev in thread] [next in thread]