[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    qt-copy
From:       Antonio Larrosa Jimenez <larrosa () kde ! org>
Date:       2004-04-03 0:49:35
Message-ID: 20040403004935.0686699E0 () office ! kde ! org
[Download RAW message or body]

CVS commit by antlarr: 

Fixes a crash in kopete because the destructor of QMNGFormat was calling a
libmng method that called a callback that was another method of the original
QMNGFormat object, and which thought that an object was still available and used it
even if it was already destroyed.
More information on the patch file.


  A            patches/0045-qmngformat-reentry.diff   1.1
  M +1 -1      patches/README   1.20
  M +2 -1      src/kernel/qmngio.cpp   1.41


--- qt-copy/src/kernel/qmngio.cpp  #1.40:1.41
@@ -311,5 +311,6 @@ QMNGFormat::QMNGFormat()
 QMNGFormat::~QMNGFormat()
 {
-    mng_cleanup(&handle);
+    consumer=0;
+    if (handle) mng_cleanup(&handle);
 }
 

--- qt-copy/patches/README  #1.19:1.20
@@ -1,4 +1,4 @@
 Please assign the numbers incrementally, and don't reuse them. The next one:
-#0045
+#0046
 
 This directory contains patches for Qt that haven't been accepted by TrollTech


[prev in list] [next in list] [prev in thread] [next in thread]