[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdelibs/kdeui (silent)
From:       Leon Bottou <leon () bottou ! org>
Date:       2004-03-18 20:05:11
Message-ID: 20040318200511.CE23099B4 () office ! kde ! org
[Download RAW message or body]

CVS commit by leonb: 

CVS SILENT: Comment changed for sendSyntheticConfigureNotifyEvent()


  M +3 -6      qxembed.cpp   1.64


--- kdelibs/kdeui/qxembed.cpp  #1.63:1.64
@@ -1313,10 +1313,7 @@ void QXEmbed::checkGrab() 
 void QXEmbed::sendSyntheticConfigureNotifyEvent() 
 {
-    // L2910: ??? [why are x and y global coordinates?]
-    //    It is bizarre that the x and y members are set to the global
-    //    position of the client window, and not the position relative
-    //    to its parent window as reported by the X11 documentation.
-    //    Few applications rely on this because the x and y components
-    //    are usually messed up by reparenting window managers.
+    // L2910: It seems that the x and y coordinates are global.
+    //        But this is what ICCCM section 4.1.5 wants.
+    //        See http://lists.kde.org/?l=kfm-devel&m=107090222032378
     QPoint globalPos = mapToGlobal(QPoint(0,0));
     if (window) {


[prev in list] [next in list] [prev in thread] [next in thread]