[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdebase/konqueror
From:       David Faure <faure () kde ! org>
Date:       2004-03-17 17:02:47
Message-ID: 20040317170247.4E99F999A () office ! kde ! org
[Download RAW message or body]

CVS commit by faure: 

Remove view->partDeleted() before deleting the KonqView.
This was the reason for KParts::slotWidgetDestroyed() being called (due to deleting the
widget before the part), and someone reported on IRC that that slot was quite dangerous,
calling "delete this" (this will go away in kde4!)
This also fixes a different crash report from Laurent, which he investigated
to be due to KHTMLPart's statusbar-extension-widgets being destroyed before the part itself.

The cvs log for the addition of partDeleted mentionned that the KonqFrame
wasn't being deleted at the time - it definitely is now even without it -,
and bundled this with another fix, so I think it wasn't necessary after all.


  M +6 -6      konq_viewmgr.cc   1.258


--- kdebase/konqueror/konq_viewmgr.cc  #1.257:1.258
@@ -796,8 +796,8 @@ void KonqViewManager::removeView( KonqVi
     grandParentContainer->removeChildFrame( parentContainer );
 
-    //kdDebug(1202) << "--- Removing view from view list, and deleting view " << view << endl;
+    //kdDebug(1202) << "--- Removing view from view list" << endl;
     m_pMainWindow->removeChildView(view);
-    view->partDeleted();
-    delete view;
+    //kdDebug(1202) << "--- Deleting view " << view << endl;
+    delete view; // This deletes the view, which deletes the part, which deletes its widget
 
     //kdDebug(1202) << "--- Deleting parentContainer " << parentContainer


[prev in list] [next in list] [prev in thread] [next in thread]