[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/kexi/kexidb/drivers/mySQL
From:       Matt Rogers <mattrogers () sbcglobal ! net>
Date:       2004-02-26 14:43:21
Message-ID: 200402260843.21381.mattrogers () sbcglobal ! net
[Download RAW message or body]

On Thursday 26 February 2004 08:16 am, Jaroslaw Staniek wrote:
> CVS commit by staniek:
>
> compile fix, thx dfaure
>
>
>   M +1 -1      mysqlcursor.cpp   1.13
>
>
> --- koffice/kexi/kexidb/drivers/mySQL/mysqlcursor.cpp  #1.12:1.13
> @@ -52,5 +52,5 @@ MySqlCursor::~MySqlCursor() {
>  bool MySqlCursor::drv_open(const QString& statement) {
>
> -        MySqlConnection *conn=(MySqlConnection*)m_conn;
> +        MySqlConnection *conn=static_cast<MySqlConnection*>(
> static_cast<Connection*>(m_conn) ); if ( (!conn)  || (!conn->m_mysql)) {
>                  //should never happen, but who knows

The double cast here seems redundant, but I haven't looked at the code. 
Shouldn't m_conn already be a Connection pointer?

Matt
[prev in list] [next in list] [prev in thread] [next in thread]