[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/filters/kword/mswrite
From:       Simon Hausmann <hausmann () kde ! org>
Date:       2004-02-14 17:01:48
Message-ID: 200402141801.49249.hausmann () kde ! org
[Download RAW message or body]

On Saturday 14 February 2004 17:58, Nicolas Goutte wrote:
> CVS commit by goutte:
>
> Use kofficefilters.po
>
>
>   M +0 -3      Makefile.am   1.12
>   M +2 -2      mswriteexport.cc   1.21
>   M +2 -2      mswriteimport.cc   1.32
>
>
> --- koffice/filters/kword/mswrite/Makefile.am  #1.11:1.12
> @@ -32,5 +32,2 @@
>  service_DATA = kword_mswrite_import.desktop kword_mswrite_export.desktop
>  servicedir = $(kde_servicesdir)
> -
> -messages: rc.cpp
> -        $(XGETTEXT) *.cc *.cpp -o $(podir)/kwordmswritefilter.pot
>
> --- koffice/filters/kword/mswrite/mswriteexport.cc  #1.20:1.21
> @@ -56,5 +56,5 @@ protected:
>          virtual void setupTranslations (void)
>          {
> -                KGlobal::locale()->insertCatalogue ("kwordmswritefilter");
> +                KGlobal::locale()->insertCatalogue ("kofficefilters");
>          }
>  };
>
> --- koffice/filters/kword/mswrite/mswriteimport.cc  #1.31:1.32
> @@ -54,5 +54,5 @@ protected:
>          virtual void setupTranslations (void)
>          {
> -                KGlobal::locale()->insertCatalogue ("kwordmswritefilter");
> +                KGlobal::locale()->insertCatalogue ("kofficefilters");
>          }
>  };

Do the filters themselves actually need their own instance? Otherwise it you 
could get rid of the local factory class and just use 'kofficefilters' as 
instance name. Just a thought :)

Simon
[prev in list] [next in list] [prev in thread] [next in thread]