[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE_3_2_BRANCH: kdepim/knotes
From:       David Faure <dfaure () klaralvdalens-datakonsult ! se>
Date:       2004-02-10 13:16:13
Message-ID: 200402101416.13589.dfaure () klaralvdalens-datakonsult ! se
[Download RAW message or body]

On Tuesday 10 February 2004 14:13, Adriaan de Groot wrote:
> On Tue, 10 Feb 2004, [utf-8] Lukáš Tinkl wrote:
> > CVS commit by lukas:
> >
> > cvs -f diff -kk -bp -u -r1.65 -r1.65.4.1 knotesapp.cpp | patch -p0 -R
> >
> > doesn't crash anymore (this should be forward ported to HEAD)
> >
> > --- kdepim/knotes/knotesapp.cpp  #1.65.4.1:1.65.4.2
> > @@ -481,6 +481,4 @@ void KNotesApp::saveConfig()
> >  void KNotesApp::saveNotes()
> >  {
> > -    ICalFormat format;
> > -
> 
> Reading the diff, this reverts the prevent-a-memory-leak patch from two
> weeks ago (or so). That is rather peculiar.

See the mail from Laurent - the memleak wasn't one, since the FileStorage
takes ownership of the format argument.

-- 
David Faure -- faure@kde.org, dfaure@klaralvdalens-datakonsult.se
Qt/KDE/KOffice developer
Klarälvdalens Datakonsult AB, Platform-independent software solutions

[prev in list] [next in list] [prev in thread] [next in thread]