[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdeextragear-2/kmldonkey/kmldonkey
From:       "Petter E. Stokke" <gibreel () project23 ! no>
Date:       2004-02-07 17:28:51
Message-ID: 200402071828.55753.gibreel () project23 ! no
[Download RAW message or body]


On Saturday 07 February 2004 18:20, Sebastian Sauer wrote:
> > Petter E. Stokke wrote:
> > On Friday 06 February 2004 13:40, Sebastian Sauer wrote:
> >> +    // this prevents dirty crashes if somebody forgot to call
> >> +    // initialise() before the content got displayed.
> >> +    if (! initdone) initialise();
> >
> > Calling initialise() is required; isn't it preferable to crash (or
> > exit with a complaint) rather than silently work around the omission?
> > Or am I missing something?
>
> Better solution for the initialise()-problem. I removed the
> showevent-handler and  moved build buildColumn() into addColumn() ...
> Now calling initialise() isn't required any longer (why was it before
> anyway?)

You're supposed to call initialise() to offer it a KConfig to use for 
layouting itself. It should make more sense once the rewrite is 
finished. :)

> I guess that's much better as to risk crashes if somebody 
> forgets to call initialise(). Ok so?

Probably not, but it certainly works for now. I'll deal with it properly 
when I get around to finishing what I started there...

-- 
Petter E. Stokke <gibreel@project23.no> http://www.gibreel.net/
PGP key: http://www.gibreel.net/key.asc
Fingerprint: 4FF3 12BD 692A 0FFF 984F  78DA 4776 81FB 1906 3A9F

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]